Fix/loading spinner issue 192#217
Merged
Nathydre merged 3 commits intonathydre21:mainfrom Mar 27, 2026
Merged
Conversation
|
@Great-2025 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
Users reported that loading spinners were not appearing during various data fetching operations, including:
Initial data loading
Search operations
Filter changes
CSV export functionality
Data refresh operations
This caused confusion and poor UX as users couldn't tell if the system was processing their requests.
🔍 Root Cause Analysis
Inconsistent Loading Implementation: Components used different loading patterns
Custom Spinners: Some components had custom SVG spinners instead of using the centralized Loading component
Missing Loading States: Several async operations lacked proper loading indicators
No Inline Feedback: Operations like search and export had no visual progress indicators
✅ Solution Overview
🎯 Key Changes Made
✅ Replaced custom spinner with centralized Loading component
✅ Added search loading indicator with inline spinner in search input
✅ Added export loading state with visual feedback on export button
✅ Added inline loading indicator for data refresh operations
✅ Improved loading states for better UX during all data operations
✅ Replaced custom SVG spinner with centralized Loading component
✅ Maintained consistent loading experience across payment flow
✅ New useLoadingState hook for consistent loading state management
✅ useAsyncLoading hook for async operations with built-in error handling
✅ Reusable patterns for future component development
closes Bug: Loading spinner not showing during data fetch #192