Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70
The stderr channel of the FFmpeg process is configured with
Stdio::piped()
by default, which is used to parse log messages for the iterator. However, this can cause problems when used withFfmpegChild.wait()
. Log messages will continue to fill up that piped stdio channel without ever being consumed. If there aren't too many log messages, the command will finish successfully. There's enough room for several hundred log lines, which is why this bug never surfaced before. However, once the whole buffer is filled, then FFmpeg will hang while it waits for more room to insert log messages (which continues indefinitely).The solution is to automatically
dropconsume the piped stderr channel whenwait()
is called.