-
-
Notifications
You must be signed in to change notification settings - Fork 943
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Improve #877 * Update pull_request_template.md * Update gradle version * Update AGP version * Update build files, use MavenPublisher plugin * Add FAQs * Fix tests
- Loading branch information
Showing
18 changed files
with
304 additions
and
348 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,14 @@ | ||
### Before you go | ||
Unless this is a simple fix (typos, bugs with obvious solution), please open an issue first. | ||
If the edited files were covered by tests, updated tests are required for merging. Please look into the tests folders and make sure you cover new code. | ||
Unless this is a simple fix (typos, bugs with obvious solution), please open an issue first so that | ||
we can discuss the best approach to address the problem. Without a reference issue and discussion, | ||
unfortunately, this PR will likely be ignored. | ||
|
||
If the edited files were covered by tests, updated tests are required for merging. | ||
Please look into the tests folders and make sure you cover new code. | ||
|
||
- Fixes ... (*issue number*) | ||
- Tests: ... (*yes/no*) | ||
- Docs updated: ... (*yes/no*) | ||
|
||
### Solution | ||
If applicable, briefly describe how the issue was addressed. | ||
If applicable, describe briefly how the issue was addressed. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
|
||
buildscript { | ||
|
||
extra["minSdkVersion"] = 15 | ||
extra["compileSdkVersion"] = 29 | ||
extra["targetSdkVersion"] = 29 | ||
extra["kotlinVersion"] = "1.3.72" | ||
|
||
repositories { | ||
google() | ||
mavenCentral() | ||
jcenter() | ||
} | ||
|
||
dependencies { | ||
classpath("com.android.tools.build:gradle:4.0.0") | ||
classpath("com.otaliastudios.tools:publisher:0.3.3") | ||
val kotlinVersion = property("kotlinVersion") as String | ||
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion") | ||
|
||
} | ||
} | ||
|
||
allprojects { | ||
repositories { | ||
google() | ||
mavenCentral() | ||
jcenter() | ||
} | ||
} | ||
|
||
tasks.register("clean", Delete::class) { | ||
delete(buildDir) | ||
} |
Oops, something went wrong.