Feat/matlab#79
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the old experimental MATLAB binding path with a documented MATLAB-via-Python compatibility layer built on the supported Python package namespace.
This branch adds a pure-Python
cea.matlabmodule with MATLAB-oriented wrapper entry points for equilibrium, rocket, shock, and detonation solves; restores the deprecated rootcea.eq_solveshim to returning the compiledEqSolution; updates typing/tests/sample scripts; and refreshes docs so MATLAB users are pointed at the supportedcea/cea.matlabworkflow instead of a separate extension.Changes
cea.matlabcompatibility module and stub file:eq_solverocket_solveshock_solvedetonation_solvecea.eq_solveas a deprecated compatibility shim, but forward it back to the compiled binding so it returns the legacy object-basedEqSolution.source/bind/matlab/ceam.pyxpath from the supported workflow.CEA_ENABLE_BIND_MATLABis a compatibility/build option rather than a separate supported MATLAB extension.Testing
Compatibility / Numerical behavior
Notes:
cea.matlab.*, and the wrapper returns flattened namespace-style results.cea.eq_solveshim now returns the legacy compiledEqSolutionobject again instead of the MATLAB-style flattened wrapper result.