make enthalpy_units required in Python API#78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finalize the Python
Reactant.enthalpy_unitsmigration by removing the implicit legacy fallback whenenthalpyis provided without units. Closes #65.This makes
enthalpy_unitsrequired wheneverReactant.enthalpyis passed, updates the typed Python surface and docs to match, and replaces the transitional warning-based regression with the new error behavior.Changes
cea.Reactantin the Python binding to raiseValueErrorwhenenthalpyis provided withoutenthalpy_unitsmolecular_weightrequirement for weight-based enthalpy units and the no-molecular_weightpath for molar unitsCHANGELOG.mdto record the breaking Python API changeTesting
Compatibility / Numerical behavior
This is an intentional Python API break:
Reactant(enthalpy=...)withoutenthalpy_units=...now raisesValueErrorinstead of falling back to implicitJ/kg.For callers already providing explicit enthalpy units, no numerical behavior is intended to change.