added LAST_VALID_SOLUTION convergence enum#77
Merged
Conversation
bmsprague
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new soft-failure status,
CEA_LAST_VALID_SOLUTION, for the incident-equilibrium shock recovery path when CEA retains a last valid incident state without converging the shock iteration. Closes #76.Motivation:
solution.converged == falsefor strict shock non-convergenceImpacted components:
Changes
CEA_LAST_VALID_SOLUTIONto the C API enum surfaceShockSolutionto distinguish:ShockSolution%convergedsemantics unchanged:truestill means the shock iteration convergedfalsecea_shock_solver_solveto return:CEA_SUCCESSfor converged shock solvesCEA_LAST_VALID_SOLUTIONfor retained incident last-valid statesCEA_NOT_CONVERGEDfor other non-converged shock outcomesLAST_VALID_SOLUTIONRuntimeWarningfor this soft-failure codesoln.last_errorinterpretable without changingsoln.convergedlast_errorbehaviorTesting
ctest -R cea_core_test -Vbuild-dev:source/bind/python/tests->51 passedCompatibility / Numerical behavior
Expected behavior changes:
CEA_NOT_CONVERGEDfailures.LAST_VALID_SOLUTIONfor this specific soft-failure path while keepingsolution.converged == false.Validation:
CEA_LAST_VALID_SOLUTIONlast_error, andconverged == false