Skip to content

Docker#28

Open
JakobKlotz wants to merge 3 commits intonasa:devfrom
JakobKlotz:docker
Open

Docker#28
JakobKlotz wants to merge 3 commits intonasa:devfrom
JakobKlotz:docker

Conversation

@JakobKlotz
Copy link
Contributor

@JakobKlotz JakobKlotz commented Mar 31, 2025

Following PR #27, here are the specific changes for a setup with Docker.

Docker

For an OS-agnostic setup with Docker, following changes were made:

  • Added a Dockerfile to create a Docker image for LHASA, including the installation of necessary dependencies and the setup of the environment.
  • Introduced a docker-compose.yaml file to facilitate the use of Docker Compose for managing the LHASA service and its volumes.
  • Described the usage in the README.md

@JakobKlotz JakobKlotz marked this pull request as ready for review March 31, 2025 16:55
@thomasastanley thomasastanley added the help wanted Extra attention is needed label Mar 31, 2025
@thomasastanley
Copy link
Contributor

Jakob,
Thanks for your contribution here. I'm not set up to test this, so it will have to wait until i get a reviewer for it.

@JakobKlotz
Copy link
Contributor Author

Hi Thomas,

thank you for looking into this. Let me know if should provide any additional context to the PR. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments