Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of fornax-images from gitlab #28

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

Conversation

zoghbi-a
Copy link

This is a final* migration of the images code from gitlab (and AWS ECR). It combines the work by @mcdonc in #24 and my original work in #10 and it is meant to replace them.

It additionally includes the structure of auto testing the images, including some tests using the demo notebooks.

The main components:

  • Each image has it own folder with Dockerfile inside (and related files). Description of the images is in the README.md file.
  • The scirpts/build.py is the main script for building and pushing the images, and updating the lock files. The description is in scripts/README.md
  • The test scripts include:
    • test_build_code.py tests the build scripts under: scripts/build.py. It runs automatically whenever a change in scripts/* is pushed (check-build-code.yml).
    • test_[image_name].py: These are tests that are run inside the containers. The are triggered whenever a new image is built and pushed to the registry (or manually; defined in run-tests.yml). The test_astro-default.py runs the demo notebooks.
  • Whenever there is a push to the repo with changes in the image folders, the images are built and tagged with the branch name (image-build.yml).
  • Making a release (typically from main) will create new image tags with the release name and stable (release.yml).

The deployment does not use these image in GH registry yet, but once we have things fully working, we will make the change.


  • pending review

mcdonc and others added 30 commits December 26, 2024 07:09
@zoghbi-a
Copy link
Author

The astro-defaul image test failure are caused by notebook failures. They'll need to be addressed in the notebook repo.

If either @mcdonc or @bsipocz are willing to review this, that would be great. However given how big it is, I am also fine with merging this as it is and then we can address issues as they arise.

@mcdonc
Copy link

mcdonc commented Dec 31, 2024

I don't have the permission to self-assign this but I will try to review this by COB Thursday, @zoghbi-a

@zoghbi-a
Copy link
Author

@bsipocz, Can you please fix the permissions in this repo by adding it to the group.

Copy link

@mcdonc mcdonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit of a weak review, mostly because I don't want to step on your toes. If it works for you, it works for me! :)

.github/workflows/image-build.yml Outdated Show resolved Hide resolved
scripts/build.py Show resolved Hide resolved
scripts/build.py Outdated Show resolved Hide resolved
@bsipocz
Copy link
Member

bsipocz commented Jan 2, 2025

Can you please fix the permissions in this repo by adding it to the group.

@zoghbi-a - no sure what happend with the team access, I'm fairly certain the team had it. Anyway, it has admin access now, and you are set as team maintainer to be able to change membership and repo access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants