-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration of fornax-images from gitlab #28
base: main
Are you sure you want to change the base?
Conversation
The If either @mcdonc or @bsipocz are willing to review this, that would be great. However given how big it is, I am also fine with merging this as it is and then we can address issues as they arise. |
I don't have the permission to self-assign this but I will try to review this by COB Thursday, @zoghbi-a |
@bsipocz, Can you please fix the permissions in this repo by adding it to the group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit of a weak review, mostly because I don't want to step on your toes. If it works for you, it works for me! :)
@zoghbi-a - no sure what happend with the team access, I'm fairly certain the team had it. Anyway, it has admin access now, and you are set as team maintainer to be able to change membership and repo access. |
This is a final* migration of the images code from gitlab (and AWS ECR). It combines the work by @mcdonc in #24 and my original work in #10 and it is meant to replace them.
It additionally includes the structure of auto testing the images, including some tests using the demo notebooks.
The main components:
README.md
file.scirpts/build.py
is the main script for building and pushing the images, and updating the lock files. The description is inscripts/README.md
test_build_code.py
tests the build scripts under:scripts/build.py
. It runs automatically whenever a change inscripts/*
is pushed (check-build-code.yml
).test_[image_name].py
: These are tests that are run inside the containers. The are triggered whenever a new image is built and pushed to the registry (or manually; defined inrun-tests.yml
). Thetest_astro-default.py
runs the demo notebooks.image-build.yml
).stable
(release.yml
).The deployment does not use these image in GH registry yet, but once we have things fully working, we will make the change.