Release/1.0.0 rc1 #191
Merged
Release/1.0.0 rc1 #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- locale module with things like number and timespan formatting - sites module with some parts of site management - ui module with some parts of UI handling This version doesn't quite work yet (several functions are stubbed out, existing only as deprecation warnings) but it works as a start to code review.
- add the `click` module for all the on_click handlers - relax the max site name length to 64 (was 50) - reduce [rich-text=tags] to 3 characters for site name length purposes - add on_gui_confirmed for rename Enter key handling - add back-button and confirm-button styles to rename window buttons
Every HUD toggle button now sets a boolean in `player_data.ui`, and `ui.update_player` checks for the values of those booleans. The button style setting is also unified with the filter button styles setting, given the "blah" and "blah_on" convention was followed in style nomenclature.
- Always pass `player` around instead of `player_index` -- only use the latter to look up values in `game.players` - Always look up `player_data` by `player.index` - Generate new instances from a unique source named `resmon.types` - This allows centralizing expected type contents, giving us an idea of what might need to be cleaned up - I'm looking at you, `yarm_site` - Remove a few unused `YARM-warn` locales - Remove unused requires - Remove unused file - Remove old migrations - Remove old remote interfaces - Add docstrings and/or type annotations
...who is actually doing the site creation/addition
+ fix the type mismatches discovered by LuaLS + move some methods around to a more "appropriate" module
I give up on trying to stop locale from knowing what a site is
The return from `pairs(t)` is the tuple `next, t, nil`, meaning that `iter_fn` and `iter_state` are unnecessary -- we already have both.
- use `next` instead of `iter_fn` in the ore tracker - include the surface in the position cache key - add migrations module - use the new migrations module to migrate the old positions - add the ability to delete tracking data for dead entities
Because ore_tracker cannot touch resmon (especially at require time) but resmon can touch ore_tracker.
This means that we don't have our migration done yet, so tracking_data.position_key is not yet available. We must query the entity to get the correct values for the position cache. Given that, there's no point saving the position key in the tracking data after all.
Default remains 300, but can be configured anywhere between 30 and 600 (every 0.5-10 seconds)
- sites are now indexed by position in the `force_data.ore_sites` table - sites no longer have an internal name - migration will copy the old names to the new name tags
|
Alright, boys and girls, this is it, the 1.0 release candidate 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.