Skip to content

Conversation

@melissawm
Copy link
Member

Testing CircleCI from forks.

@melissawm melissawm closed this Jul 26, 2025
@melissawm melissawm reopened this Jul 26, 2025
@DragaDoncila
Copy link
Contributor

@melissawm since you're looking at this I will note that it doesn't even seem to matter if it's from forks or not 😭 (I can't find a PR right now from this repo but I'm sure there have been some...)

@DragaDoncila
Copy link
Contributor

Ok here's one from not a fork and the preview was still skipped: #84

@melissawm
Copy link
Member Author

@melissawm
Copy link
Member Author

I think we can't use the on: pull request trigger. I don't see this example in the action README and due to the link I mentioned above I think that creates permissions issues on forks. We can give this one a try - I think it will only run after merged to main, but you can see already it was not skipped - just wasn't triggered from the last commit.

@melissawm
Copy link
Member Author

See this note in the action readme:

Note: The standard PR-to-main-repo-from-branch-in-a-fork workflow might not activate the action. For changes to take effect, changes might need to be made to to the default branch in a repo with the action enabled. For example, you could iterate directly in master, or in master of a fork. This seems to be a limitation of the fact that CircleCI uses the status (rather than app) API and that this is always tied to the master/default branch of a given repository.

@psobolewskiPhD
Copy link
Member

Approved, I think this could be merged as is to see if it resolves the issue -- it won't break anything -- and then can iterate?

@melissawm
Copy link
Member Author

Yeah I think so. Thanks!

@psobolewskiPhD psobolewskiPhD merged commit 6c1a563 into napari:main Jul 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants