Fix bug with parsing project URLs #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I don't understand tbh why the error thrown during the processing of this plugin didn't bubble to the top, but it could be a |
willingc
approved these changes
Jul 24, 2025
Collaborator
willingc
left a comment
willingc
left a comment
There was a problem hiding this comment.
Tested locally and it worked fine.
Collaborator
I think that the error handling of the original code could be improved. As an FYI, I have the fetch write csvs to the _build/data directory so we can check a bit more easily. |
DragaDoncila
added a commit
that referenced
this pull request
Aug 13, 2025
@DragaDoncila I used this notebook to do a quick check for a plugin by name during debug. Follow-up to #92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #84 I introduced a bug with parsing the URLs for plugins that don't declare a
project_urlfield but use the oldhomepagespec. This PR fixes that bug.@willingc I'm pretty sure this closes #91 but I guess we'll have to deploy to be certain 🙄