-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update conf.py to use packaging to detect dev vs release versions #631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🚢
I'm not sure if it's caching or the deploy workflow but stable says (0.5.6) but directs to 0.6.0 🤷🏼♀️ |
Can you explain where? when I go to napari.org stable is 0.5.6 and has for example the missing screenshot in installation guide. When I use the circle build, it's just building dev, so it should also have stable as napari.org stable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should deploy prerelease to separate dirctory. (for 0.6.0a1 it should be 0.6.0) but we should not parse it manually when packaging
is available.
Co-authored-by: Grzegorz Bokota <[email protected]>
Please update the title to reflect the current state |
dev
Comments were addressed + suggestions were accepted
References and relevant issues
If you go to dev docs right now:
https://napari.org/dev/index.html
The sidebar link to the release notes is broken, I think because the version is being treated as a release and not dev.
It points to:
https://napari.org/dev/release/release_0_6_0a0.html
which doesn't exist.
instead of the index.html which would be used for a dev release:
https://napari.org/dev/release/index.html
So in this PR I use packaging to check if a version is a dev version and also uses packaging to get just the base version number of pre-releases, so we will get release_0_6_0.html