Move links out of navbar and into sidebar / other areas. #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description Add a -c option to suppress the detached head warning when building docs, specifically when checking out a tag.
…unch_cli_image) with nbscreenshots (napari#606)
# References and relevant issues Partially addresses napari#600 by improving the Advanced Topics landing page. # Description This PR adds cards to guide the reader to the npe2 specification. It also more clearly indicates that napari plugin engine v1 is deprecated. --------- Co-authored-by: Peter Sobolewski <[email protected]>
# Description This PR updates the Circle CI orb and image for Python. If this is accepted here, I will open a PR to update the `napari/napari` repo as well. Co-authored-by: Melissa Weber Mendonça <[email protected]> Co-authored-by: Peter Sobolewski <[email protected]>
…i#609) # References and relevant issues <!-- What relevant resources were used in the creation of this PR? If this PR addresses an existing issue on the repo, please link to that issue here as "Closes #(issue-number)". If this PR adds docs for a napari PR please add a "Depends on <napari PR link>" --> Closes napari#595 # Description 1. Changes plugin landing page tabs to link immediatelly to 'finding_and_installing_plugins' and the napari hub, rather than to the index of start_using_plugins, which contained nothing more than the same information now on the landing page. 2. Removes index from start_using_plugins because it is not needed 3. Updates TOC to remove the index and using finding and installing plugins as top level header <!-- Final Checklist - If images included: I have added [alt text](https://webaim.org/techniques/alttext/) If workflow, documentation build or deployment change: - My PR is the minimum possible work for the desired functionality - I have commented my code, to let others know what it does -->
# Description This PR does the following: - adds section headings to the contributing workflow for contributor convenience - reorders the contribution guides sections to reflect where new contributors will commonly begin - combines UI related contributions into one UI section with subsections Co-authored-by: Peter Sobolewski <[email protected]>
github-actions
bot
added
documentation
|
I have no idea why so many files were edited? I know I rebased or something ... maybe that was the wrong thing to do? I thought that erased the commit history, not kept it, and it was merging that would have kept all the commits? |
|
Looking at the commit history it looks like you rebased main onto this branch rather than the other way? Hard to say without knowing your commands, maybe check your shell history and post what you entered? |
TimMonko
changed the title
|
I think that you can |
jni
pushed a commit
that referenced
this pull request
Mar 14, 2025
# References and relevant issues Closes #615. Follow up of #610. Remake of #617 because I got confused with the commit history and merging # Description I think the navbar is a bit too cluttered due to the 'More' section being propagated to the sidebar in smaller width screens (and generally being finnicky) 1. Moves 3 lower-value (I still love them) links out of the navbar: blog, zulip chat, and workshop template 2. Moves blog to homepage sidebar (confirms there is a link to blog in community) 3. Moves workshop template link to Workshops page in Usage, also adds a link to Contributing index 4. Removes zulip link in favor of presence in homepage sidebar and presence in footer. If we want to keep this in header we should move the footer link up to the header in theme 5. Adds troubleshooting link to homepage sidebar (**check** that this is internally referenced correctly, I can't do https://napari.org/troubleshooting.html/ like I can for other internal refs, it 404s)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up / depends on #610. Closes #615
Description
I think the navbar is a bit too cluttered due to the 'More' section being propagated to the sidebar in smaller width screens (and generally being finnicky)
TO-DO: