-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create proof of concept that the napari sphinx theme doesn't need to be maintained separatedly #592
Conversation
Wow! Thanks for the effort on this one! I'm of two minds about this. Also I noticed |
@psobolewskiPhD This really was a proof of concept (wasn't aware of napari-animation). I think that the benefit of this PR will be to simplify the napari sphinx theme. Doing the proof of concept, I removed a bunch of cruft and added some best practices. Happy to do it in the napari sphinx theme repo. |
- pygments highlighting | ||
- headless on mac | ||
- fix styling for This Page source | ||
- search wtf keyboard shortcut (where did you go) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂
Closing as this is a proof of concept, and I'm satisfied with the results. |
References and relevant issues
This PR is a proof of concept.
Description
Motivation
Maintaining a custom theme adds complexity and maintenance burden. Ideally, one would opt for a custom theme
only if a major feature could not be implemented by another well maintained theme.
Currently, our docs workflow and contribution is more complex than needed if someone is trying to do a local documenation build.
Proof of Concept
This PR demonstrates the possibilities:
_templates
_static
Next steps
This is by no means merge ready. It was basically to prove to myself that we could create a napari styled theme using the pydata sphinx theme and remove the need to maintain a separate repo for the napari-sphinx-theme.
This all works locally on my mac. Let's see if this draft can pass our CI.