Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.6 relnotes updates #552

Merged
merged 8 commits into from
Jan 21, 2025
Merged

0.5.6 relnotes updates #552

merged 8 commits into from
Jan 21, 2025

Conversation

jni
Copy link
Member

@jni jni commented Jan 18, 2025

Updates before final 0.5.6 release

  • use ghifs with raw html to show video of polyline tool in action
  • Add note about installing with napari[all]
  • update date
  • add remaining 0.5.6 PRs

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 18, 2025
@jni jni added this to the 0.5.6 milestone Jan 20, 2025
@jni
Copy link
Member Author

jni commented Jan 20, 2025

Grrr, looks like ghifs videos don't render on Firefox. 😢

@TimMonko
Copy link
Contributor

Yes, not loading on Firefox for me either.

Btw L66 and L70 are duplicated, but it went let me comment

@Czaki
Copy link
Contributor

Czaki commented Jan 20, 2025

use raw html like in 0.5.5 release notes

```{raw} html

@melissawm
Copy link
Member

Can we convert this to a webm to make it fit? I feel so old I don´t even know what a ghif is 😭

@Czaki
Copy link
Contributor

Czaki commented Jan 20, 2025

In general, when I open the link in Firefox browser, the film runs properly. So it is problem withe mebeding.

@jni
Copy link
Member Author

jni commented Jan 21, 2025

use raw html like in 0.5.5 release notes

Yes, that means adding the file to the repo and using up our already-over-budget build size, though, so I try to avoid it. But I'll do it here.

I feel so old I don´t even know what a ghif is

@melissawm haha not ghif, ghifs, and don't worry it's not you, it's an obscure reference to this old Twitter thread:

CleanShot 2025-01-21 at 17 06 41@2x

@jni
Copy link
Member Author

jni commented Jan 21, 2025

In general, when I open the link in Firefox browser, the film runs properly. So it is problem withe embedding.

That's interesting @Czaki. Indeed the caniuse for mp4 shows lots of green. Lemme try that first.

@jni
Copy link
Member Author

jni commented Jan 21, 2025

New embed worked! 🥳 🚀

https://output.circle-artifacts.com/output/job/2b42a689-6186-4775-9ea3-d23e49d74356/artifacts/0/docs/docs/_build/html/release/release_0_5_6.html

If someone can approve and merge this I will push rc1. Should we then do a same day release or wait 24h?

@jni jni marked this pull request as ready for review January 21, 2025 07:04
@jni
Copy link
Member Author

jni commented Jan 21, 2025

Should we then do a same day release or wait 24h?

If we do same day then I'll update this PR to remove the draft note.

@jni
Copy link
Member Author

jni commented Jan 21, 2025

Should we then do a same day release or wait 24h?

I've reviewed my notifications and the milestone in more detail and I'm happier to just release quickly after rc1, so I removed the draft note. Any objections?

@jni
Copy link
Member Author

jni commented Jan 21, 2025

@Czaki, any thoughts here?

Copy link
Contributor

@Czaki Czaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loks ok

@jni jni merged commit e70c1e2 into napari:main Jan 21, 2025
9 checks passed
@jni jni deleted the 0.5.6-relnotes-updates branch January 21, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants