-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.5.6 relnotes updates #552
Conversation
Grrr, looks like ghifs videos don't render on Firefox. 😢 |
Yes, not loading on Firefox for me either. Btw L66 and L70 are duplicated, but it went let me comment |
use raw html like in 0.5.5 release notes docs/docs/release/release_0_5_5.md Line 38 in 995fb28
|
Can we convert this to a webm to make it fit? I feel so old I don´t even know what a ghif is 😭 |
In general, when I open the link in Firefox browser, the film runs properly. So it is problem withe mebeding. |
Yes, that means adding the file to the repo and using up our already-over-budget build size, though, so I try to avoid it. But I'll do it here.
@melissawm haha not ghif, ghifs, and don't worry it's not you, it's an obscure reference to this old Twitter thread: |
That's interesting @Czaki. Indeed the caniuse for mp4 shows lots of green. Lemme try that first. |
New embed worked! 🥳 🚀 If someone can approve and merge this I will push rc1. Should we then do a same day release or wait 24h? |
If we do same day then I'll update this PR to remove the draft note. |
I've reviewed my notifications and the milestone in more detail and I'm happier to just release quickly after rc1, so I removed the draft note. Any objections? |
@Czaki, any thoughts here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
loks ok
Updates before final 0.5.6 release