fix: correct socket state checks and handle listen errors in netsyscall #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinor
force-pushed
the
netsyscall_tcp_EADDRINUSE
branch
2 times, most recently
from
3fad3b9 to
394ea81
Compare
rinor
force-pushed
the
netsyscall_tcp_EADDRINUSE
branch
from
394ea81 to
23bf400
Compare
francescolavra
approved these changes
Sep 27, 2024
| if (!lw) { | ||
| rv = lwip_to_errno(err); | ||
| goto unlock_out; | ||
| } |
There was a problem hiding this comment.
Right, if the SO_REUSEADDR socket option is enabled, the bind() system call doesn't return -EADDRINUSE if another socket is bound to the same address, so we have to check for in-use addresses in the listen() system call. This is the correct fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #2066