Page faults: add support for custom fault handlers #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code is assuming that the completion passed to pagecache_read_sg() is a contextual closure. This prevents reading from the page cache with a completion that is not a contextual closure, such as when the reading context suspends itself and the completion resumes the suspended context (this happens in the Nvidia GPU klib when reading the GPU firmware file). This change allows reading from the page cache with non-contextual completion closures.
This allows custom mmap() implementations for specific file descriptors to handle page faults on mmap()ed memory. This feature is used by the Nvidia GPU klib. The new_pending_fault_locked() function is no longer static so that it can be called from an arbitrary fault handler when a fault cannot be resolved synchronously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows custom mmap() implementations for specific file descriptors to handle page faults on mmap()ed memory. This feature
is used by the Nvidia GPU klib.
The first commit allows reading from the page cache with non-contextual completion closures, such as when the reading context suspends itself and the completion resumes the suspended context (this happens in the Nvidia GPU klib when reading the GPU firmware file).