Refactor AST to improve types #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change expref detection - refactor visit FieldNode - refactor visit IndexNode - refactor visit ValueProjectionNode - refactor visit FilterProjectionNode - refactor visit FlattenNode - refactor visit OrExpressionNode - refactor visit AndExpressionNode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major change of this PR is to define strictly typed AST nodes to improve flow analysis and reduce the number of required type casts.
As part of this I tied in some refactoring of the main visit method in the TreeInterpreter, as the restructure of the AST enabled the improvements.