Add support for generics <T> #880
Conversation
- Now using XmlDeserialize. - Update PdbxFile class to use XML attributes. - Add new fields to methods and classes to take advantage of new XML reader implementation.
- Add new constructor to CorDebugClass to accept type spec. - Add code to handle generics in CorDebugValue.
***NO_CI***
***NO_CI***
***NO_CI***
- Rework vairables declaration to add sign group variables. ***NO_CI***
- Fix project path. ***NO_CI***
- Update task installing sign tool with new .NET Foundation tool. - Migrate sign task to use new tool. - Update file list for sign tool. ***NO_CI***
- Fix options passed to sign tool. ***NO_CI***
- Remove private Azure feed from nuget.config. ***NO_CI***
- Update sign version. - Update config for github release tasks. - No more build on tags. ***NO_CI***
- Fix config for github publish task. ***NO_CI***
- Fix syntax in label list. ***NO_CI***
…nanoclr` (#825) ***NO_CI***
***NO_CI***
***NO_CI***
|
Amazing work! Can't wait to test all this! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
VisualStudio.Extension-2022/packages.lock.json (1)
1870-1876: New Project Dependency: nanoFramework.Tools.BuildTasksA new project-level dependency for
nanoFramework.Tools.BuildTaskshas been added. This entry specifies dependencies on"Microsoft.Build.Framework": "[17.12.6, )"and"Microsoft.Build.Utilities.Core": "[17.11.4, )". Please verify that these dependency version ranges are aligned with the upstream requirements and that any consuming projects are compatible with these versions.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (6)
VisualStudio.Extension-2019/VisualStudio.Extension-vs2019.csprojis excluded by none and included by noneVisualStudio.Extension-2022/VisualStudio.Extension-vs2022.csprojis excluded by none and included by nonemetadata-processoris excluded by none and included by nonenf-debuggeris excluded by none and included by nonevs-extension.shared/CorDebug/CorDebugFunction.csis excluded by none and included by nonevs-extension.shared/CorDebug/CorDebugProcess.csis excluded by none and included by none
📒 Files selected for processing (2)
VisualStudio.Extension-2019/packages.lock.json(1 hunks)VisualStudio.Extension-2022/packages.lock.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: nanoframework.nf-Visual-Studio-extension (VS2019)
- GitHub Check: nanoframework.nf-Visual-Studio-extension (VS2022)
- GitHub Check: nanoframework.nf-Visual-Studio-extension (Get_Build_Options)
🔇 Additional comments (3)
VisualStudio.Extension-2022/packages.lock.json (2)
1877-1883: Updated Dependency: nanoFramework.Tools.Debugger.NetThe dependency for
nanoFramework.Tools.Debugger.Nethas been refactored from a direct dependency to a project-level dependency. It now declares dependencies on:
"Polly": "[7.2.4, )""System.IO.Ports": "[8.0.0, )"These changes aim to better manage dependency resolution. Please confirm that downstream components correctly reference the updated project-level dependency and that version constraints meet expectations.
1884-1888: Updated Dependency: nanoFramework.Tools.MetadataProcessor.MsBuildTaskThe dependency for
nanoFramework.Tools.MetadataProcessor.MsBuildTaskhas been updated to a project dependency. It now requires"System.Text.Json": "[8.0.5, )". Ensure that consuming projects are compatible with this version constraint and that the changes are consistent with dependency management across the solution.VisualStudio.Extension-2019/packages.lock.json (1)
1838-1856: Updated Project-Level Dependency Entries for nanoFramework ToolsThe changes in this range transition the affected packages from being managed as Direct dependencies to Project-level dependencies. In particular:
- nanoFramework.Tools.BuildTasks now remains defined as a project with its dependencies on
"Microsoft.Build.Framework"and"Microsoft.Build.Utilities.Core"constrained to[16.11.0, ).- nanoFramework.Tools.Debugger.Net has been revamped to a project dependency with its required packages now specified as:
"Polly": "[7.2.4, )", and"System.IO.Ports": "[8.0.0, )".- nanoFramework.Tools.MetadataProcessor.MsBuildTask is similarly redefined as a project dependency, now depending on
"System.Text.Json": "[8.0.5, )".These changes align with the updated dependency management strategy outlined in the PR objectives and the high-level summary. They ensure consistency with the upcoming shift from direct references to NuGet package dependency management, thereby enhancing maintainability and future-proofing the project.
Please verify that this update integrates seamlessly with the overall dependency resolution mechanism and is consistent with similar changes made in the VisualStudio.Extension-2022 lock file.
- Also rename fields to follow code style.
*** merge upstream ***
- Now downloading sub-modules.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
azure-pipelines.yml (1)
338-341: Clarification: Enable Submodules for VS2022 JobThe VS2022 job’s checkout step now explicitly enables submodules with
submodules: true. This change ensures that any required submodules—possibly needed for resolving the new generic support dependencies or related projects—are correctly checked out during the build. Please verify that:
- These submodules are indeed required only for the VS2022 job.
- There isn’t a need to enable submodules for the VS2019 job unless those builds also depend on them.
If the intent is to differentiate between the two environments (e.g., using distinct dependency mechanisms), this configuration is appropriate. Otherwise, consider consolidating the checkout settings for consistency.
🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 338-338: wrong indentation: expected 4 but found 2
(indentation)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
nanoFramework.Tools.VisualStudio.slnis excluded by none and included by none
📒 Files selected for processing (1)
azure-pipelines.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: nanoframework.nf-Visual-Studio-extension (VS2019)
- GitHub Check: nanoframework.nf-Visual-Studio-extension (VS2022)
- GitHub Check: nanoframework.nf-Visual-Studio-extension (Get_Build_Options)
- VS2022 job is not checking out sub-modules anymore.
- Add task to upload VSIX to Open VSIX gallery on develop builds. - Fix condition to create github release only on commits to main branch.
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
VisualStudio.Extension-2022/source.extension.vsixmanifestis excluded by none and included by none
📒 Files selected for processing (1)
azure-pipelines.yml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: nanoframework.nf-Visual-Studio-extension (VS2022)
- GitHub Check: nanoframework.nf-Visual-Studio-extension (VS2019)
- GitHub Check: nanoframework.nf-Visual-Studio-extension (VS2022)
- GitHub Check: nanoframework.nf-Visual-Studio-extension (VS2019)
- GitHub Check: nanoframework.nf-Visual-Studio-extension (Get_Build_Options)
- GitHub Check: nanoframework.nf-Visual-Studio-extension (Get_Build_Options)
🔇 Additional comments (1)
azure-pipelines.yml (1)
312-312: Release trigger condition improved—good practice.The release creation step now triggers only on the main branch, which is a best practice to avoid accidental releases from develop or other branches.
Also applies to: 511-511
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Summary by CodeRabbit