-
-
Notifications
You must be signed in to change notification settings - Fork 53
EditorConfig file added and documented #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
I've updated the documentation page. I've also added a .editorconfig with only spell checker configuration, so the spell checker can be used for the markdown pages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All up, looks good. @josesimoes if you can check if that works fine all up for SNTP, I'm pretty much in favor of having this available in the various repos.
@frobijn one of the challenge is going to be the complex https://github.com/nanoframework/nanoFramework.IoT.Device repository!
That is not a repository that's on my list to look closely at. But be assured, there are many ways to get it to work. Two hints:
|
Description
Added documentation about the .editorconfig file. Another pull request will be made for the nanoff repository.
As PoC this is being applied to SNTP class library. Upon succesfull testing we'll move to the other repos as well.
Adding the PR here for reference nanoframework/nanoFramework.Networking.Sntp#134
Motivation and Context
Apparently the nanoFramework uses an appalling coding style as it is different from mine :-) The documentation describes that there is a vssettings file that contains the coding style. As a potential contributor I'm not prepared to modify the Visual Studio settings and to turn off automatic formatting. Fortunately there is a much better way to share these settings, at least for C# - Visual Studio supports adding the settings to an EditorConfig file.
It is possible to generate an EditorConfig file from the Visual Studio settings. As I don't have the correct settings, I've just added some of the formatting and naming rules. If I start contributing to the nanoFramework code, an EditorConfig file will also be added if it is not already present.
Perhaps one of the team members could generate a more complete version and add it to the repositories and documentation?
Types of changes
Checklist: