Skip to content

Update 1 NuGet dependencies #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
<Reference Include="nanoFramework.Benchmark, Version=1.0.108.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.Benchmark.1.0.108\lib\nanoFramework.Benchmark.dll</HintPath>
</Reference>
<Reference Include="nanoFramework.Logging, Version=1.1.156.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.Logging.1.1.156\lib\nanoFramework.Logging.dll</HintPath>
<Reference Include="nanoFramework.Logging, Version=1.1.157.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.Logging.1.1.157\lib\nanoFramework.Logging.dll</HintPath>
</Reference>
<Reference Include="nanoFramework.Runtime.Native, Version=1.7.11.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.Runtime.Native.1.7.11\lib\nanoFramework.Runtime.Native.dll</HintPath>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<packages>
<package id="nanoFramework.Benchmark" version="1.0.108" targetFramework="netnano1.0" />
<package id="nanoFramework.CoreLibrary" version="1.17.11" targetFramework="netnano1.0" />
<package id="nanoFramework.Logging" version="1.1.156" targetFramework="netnano1.0" />
<package id="nanoFramework.Logging" version="1.1.157" targetFramework="netnano1.0" />
<package id="nanoFramework.Runtime.Native" version="1.7.11" targetFramework="netnano1.0" />
<package id="nanoFramework.System.Collections" version="1.5.67" targetFramework="netnano1.0" />
<package id="nanoFramework.System.Diagnostics.Stopwatch" version="1.2.862" targetFramework="netnano1.0" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
},
"nanoFramework.Logging": {
"type": "Direct",
"requested": "[1.1.156, 1.1.156]",
"resolved": "1.1.156",
"contentHash": "88QonPIXQnfNqs7lPGyS1r+upesv5O8EhwYOHhYGv247ah0pnL2vBKDbR4lRvB2aFOij7ZrbgiuaseKWy4vH/Q=="
"requested": "[1.1.157, 1.1.157]",
"resolved": "1.1.157",
"contentHash": "x+NjFgtfz9vFSuhkvSftvvZ4t6h82pUKZo/yAn8M1KSFKhOzy3x12wyRGqOoIzGdY9XobpnBO2V80Rv8huoj3Q=="
Comment on lines +19 to +21
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify updated nanoFramework.Logging version and contentHash

The dependency has been bumped from 1.1.156 to 1.1.157 and the contentHash updated. Please confirm that version 1.1.157 is published on NuGet and that the contentHash correctly reflects the package contents to avoid any lock‐file inconsistencies.


🏁 Script executed:

#!/bin/bash
# Verify that nanoFramework.Logging 1.1.157 is available in the NuGet feed
if curl -s https://api.nuget.org/v3-flatcontainer/nanoframework.logging/index.json | grep -q '"1.1.157"'; then
  echo "✅ Version 1.1.157 exists on NuGet."
else
  echo "❌ Error: Version 1.1.157 not found in NuGet feed."
  exit 1
fi

Length of output: 182


🏁 Script executed:

#!/bin/bash
set -e
# Download the nupkg for nanoFramework.Logging 1.1.157
curl -sL -o pkg.nupkg https://api.nuget.org/v3-flatcontainer/nanoframework.logging/1.1.157/nanoframework.logging.1.1.157.nupkg

# Compute SHA-512 hash and Base64‐encode it
computed_hash=$(python3 - << 'EOF'
import hashlib, base64, sys
data = open('pkg.nupkg', 'rb').read()
print(base64.b64encode(hashlib.sha512(data).digest()).decode())
EOF
)

expected_hash="x+NjFgtfz9vFSuhkvSftvvZ4t6h82pUKZo/yAn8M1KSFKhOzy3x12wyRGqOoIzGdY9XobpnBO2V80Rv8huoj3Q=="

if [ "$computed_hash" = "$expected_hash" ]; then
  echo "✅ contentHash matches expected value."
else
  echo "❌ contentHash mismatch: computed $computed_hash"
  exit 1
fi

Length of output: 812


Incorrect contentHash for nanoFramework.Logging 1.1.157

The computed SHA-512 Base64 of the downloaded 1.1.157 nupkg (oCK20uudtK6z52iu5/3Vm+jWYP+gbg4R4+Op8Tb06iTnY813AzGHgrM92pHiPCDRg+u5frDWGQ6x/RbldckMMg==) does not match the lock‐file’s current contentHash. Please update it:

  • nanoFramework.System.Text.RegularExpression.Benchmark/packages.lock.json (line 21)
-    "contentHash": "x+NjFgtfz9vFSuhkvSftvvZ4t6h82pUKZo/yAn8M1KSFKhOzy3x12wyRGqOoIzGdY9XobpnBO2V80Rv8huoj3Q=="
+    "contentHash": "oCK20uudtK6z52iu5/3Vm+jWYP+gbg4R4+Op8Tb06iTnY813AzGHgrM92pHiPCDRg+u5frDWGQ6x/RbldckMMg=="
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"requested": "[1.1.157, 1.1.157]",
"resolved": "1.1.157",
"contentHash": "x+NjFgtfz9vFSuhkvSftvvZ4t6h82pUKZo/yAn8M1KSFKhOzy3x12wyRGqOoIzGdY9XobpnBO2V80Rv8huoj3Q=="
"requested": "[1.1.157, 1.1.157]",
"resolved": "1.1.157",
- "contentHash": "x+NjFgtfz9vFSuhkvSftvvZ4t6h82pUKZo/yAn8M1KSFKhOzy3x12wyRGqOoIzGdY9XobpnBO2V80Rv8huoj3Q=="
+ "contentHash": "oCK20uudtK6z52iu5/3Vm+jWYP+gbg4R4+Op8Tb06iTnY813AzGHgrM92pHiPCDRg+u5frDWGQ6x/RbldckMMg=="

},
"nanoFramework.Runtime.Native": {
"type": "Direct",
Expand Down