Skip to content

Remove native version and use native contract hash - #49

Merged
josesimoes merged 1 commit into
developfrom
new-assembly-format
Oct 12, 2026
Merged

josesimoes merged 1 commit into
developfrom
new-assembly-format

Conversation

@josesimoes

Copy link
Copy Markdown
Member

Description

  • The AssemblyNativeVersion attribute is removed from AssemblyInfo.cs.
  • The nuspec description now references the native contract hash and the nuspec tags include the nfnc tag with the native contract hash.
  • The nanoFramework.CoreLibrary package is updated to 2.0.0-preview.63 in the nuspec, packages.config, nfproj and packages.lock.json files.

Motivation and Context

How Has This Been Tested?

Built by the CI pipeline of this PR.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

🤖 Generated with Claude Code

- Remove AssemblyNativeVersion attribute from AssemblyInfo.
- Replace native version and checksum with native contract hash in nuspec description and add nfnc tag.
- Update nanoFramework.CoreLibrary to 2.0.0-preview.63.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: nanoframework/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 339b7f84-d5c2-45ce-b578-ee97af9ef642

📥 Commits

Reviewing files that changed from the base of the PR and between ee6088b and 4239f20.


📒 Files selected for processing (5)
  • System.Device.Pwm/Properties/AssemblyInfo.cs
  • System.Device.Pwm/System.Device.Pwm.nfproj
  • System.Device.Pwm/packages.config
  • System.Device.Pwm/packages.lock.json
  • nanoFramework.System.Device.Pwm.nuspec

💤 Files with no reviewable changes (1)
  • System.Device.Pwm/Properties/AssemblyInfo.cs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Summary

Summary by CodeRabbit

  • Compatibility
    • Updated the PWM package to use a newer Core Library preview.
    • Package compatibility is now specified by native contract hash rather than native version and checksum.
    • The package includes an updated compatibility tag for target selection.

Walkthrough

The PWM project advances its CoreLibrary dependency to 2.0.0-preview.63. Its package metadata now specifies a native contract hash, and its assembly metadata no longer declares an AssemblyNativeVersion attribute.

Changes

PWM package update

Layer / File(s) Summary
Package metadata and dependency update
System.Device.Pwm/Properties/AssemblyInfo.cs, nanoFramework.System.Device.Pwm.nuspec, System.Device.Pwm/System.Device.Pwm.nfproj, System.Device.Pwm/packages.config, System.Device.Pwm/packages.lock.json
The project and package dependency references use CoreLibrary 2.0.0-preview.63. The package requirement uses a native contract hash instead of a native version and checksum. The assembly metadata no longer declares AssemblyNativeVersion.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Suggested labels: Area: Config-and-Build

Suggested reviewers: nfbot


Merge Risk: ⚪ Minimal · up to 4239f

No confirmed issue blocks this change. Confirm that firmware supports the package’s native contract hash before release.

Pre-merge checks | Passed 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check Passed The title accurately summarizes the main changes, is concise at 50 characters, contains no issue or pull request references, and does not end with a full stop.
Description check Passed The description clearly explains the removed attribute, native contract hash changes, dependency update, testing status, and change classification. It is directly related to the changeset.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nfbot

nfbot commented Oct 12, 2026

Copy link
Copy Markdown
Member

⚠️ Native declaration update required!

The native contract hash of nanoFramework.System.Device.Pwm has changed. The native declaration in nf-interpreter must be updated before this package can be released.

Previously published This build
Native contract hash 0xCF40DA96 0xB3C82548

👉 Tracking issue: nanoframework/Home#1910

The issue contains a link to the stubs artifact from this build and instructions for GitHub Copilot to perform the update.

@josesimoes

Copy link
Copy Markdown
Member Author

@coderabbitai review

@josesimoes
josesimoes enabled auto-merge (squash) October 12, 2026 16:02
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@josesimoes
josesimoes merged commit 0b2c6e9 into develop Oct 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants