Refactor/change cache dir location #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nos framework isnt included so nos_code_dir wouldnt return anything anyway
|
I think #43 will handle this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it turns out this engine hasn't been properly vendoring the pip modules. Even though we were specifying the "src" dir as a cache_dir, the
pip installwasn't actually storing the modules in there. After some research, it was confirmed that thepip installwas installing into global package space. This means that everynanobox buildwould completely wipe the installed modules and re-install them. Additionally, it means the "src" cache_dir was pointless.This change adds proper vendoring for python, into the
.nanobox/pipcache_dir.