Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lock-free ensure that column doesn't exist #1383

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Add lock-free ensure that column doesn't exist #1383

merged 1 commit into from
Jan 29, 2025

Conversation

InverseIntegral
Copy link
Contributor

No description provided.

@InverseIntegral InverseIntegral requested a review from n-g January 29, 2025 13:35
@InverseIntegral InverseIntegral force-pushed the matteo/add-lock-free-ensure-column-doesnt-exists branch from 5869bde to da328b8 Compare January 29, 2025 13:36
n-g
n-g approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@n-g n-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

library/oss/postgres/prepare/database/functions.sql Outdated
LANGUAGE plpgsql AS
$func$
BEGIN
IF NOT EXISTS (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IF EXISTS

@InverseIntegral InverseIntegral force-pushed the matteo/add-lock-free-ensure-column-doesnt-exists branch from da328b8 to 7c6b3f1 Compare January 29, 2025 13:47
@InverseIntegral InverseIntegral added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit bfd2a10 Jan 29, 2025
18 checks passed
@InverseIntegral InverseIntegral deleted the matteo/add-lock-free-ensure-column-doesnt-exists branch January 29, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n-g n-g n-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@InverseIntegral @n-g