(WIP) Don't throw fatal errors when cert_override.txt sync fails#88
Open
JeremyRand wants to merge 1 commit intonamecoin:masterfrom
Open
(WIP) Don't throw fatal errors when cert_override.txt sync fails#88JeremyRand wants to merge 1 commit intonamecoin:masterfrom
JeremyRand wants to merge 1 commit intonamecoin:masterfrom
Conversation
Instead just stop resolving domains until the error goes away. This fixes issues where ncdns would exit if, for example, Namecoin Core wasn't running or wasn't fully synced when ncdns was launched.
Member
Author
|
I haven't yet tested whether this breaks anything else, hence the (WIP) label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead just stop resolving domains until the error goes away. This
fixes issues where ncdns would exit if, for example, Namecoin Core
wasn't running or wasn't fully synced when ncdns was launched.