Added DomainRecord and Record classes to the codebase#549
Draft
junekomeiji wants to merge 1 commit intonamecoin:masterfrom
Draft
Added DomainRecord and Record classes to the codebase#549junekomeiji wants to merge 1 commit intonamecoin:masterfrom
junekomeiji wants to merge 1 commit intonamecoin:masterfrom
Conversation
…xtensibility of records assigned to a certain domain.
Member
|
Thanks Rose! I'll review this in the next couple days. |
Member
|
Per discussion in the #namecoin-dev meeting last month, this PR is on hold to avoid colliding with ongoing collaboration with Q and IETF. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the DomainRecord and Record classes in the codebase alongside unit tests for them to allow easy adding and removing of records assigned to a particular namecoin domain. These new record classes means that it is easy to extend the records to accept new data types, as well as reducing the amount of redundant code needed to write verifiers for each particular data type.