Open
Conversation
3 tasks
grarco
commented
Jun 4, 2025
| if let Some(block_proposer) = | ||
| &self.header.proposer_address_namada | ||
| { | ||
| balance_changes.push(BalanceChange::new( |
Contributor
Author
There was a problem hiding this comment.
A better approach would be to request this balance update only if the gas price of this tx exceeds the minimum price imposed by the protocol. The problem is that we'd need the updated gas costs for this check and this would introduce a dependency between the parameters and the chain microservices
grarco
force-pushed
the
grarco/fee-foreign-reserve
branch
from
4baf758 to
dd4fa85
Compare
sug0
approved these changes
Jun 9, 2025
Contributor
|
Remember not to merge this until namada-net/namada#4644 is ultimately merged, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #379.
Depends on namada-net/namada#4644.
Updates the balance of PGF (fee foreign reserve) when a transaction pays the gas fees with a non-native token