Skip to content

Commit

Permalink
fix invalid autocommit disable on connect()
Browse files Browse the repository at this point in the history
  • Loading branch information
nakagami committed Mar 22, 2019
1 parent fe596dd commit 0846b32
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion lib/firebirdex/protocol.ex
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ defmodule Firebirdex.Protocol do
database = to_charlist(opts[:database])
case :efirebirdsql_protocol.connect(hostname, username, password, database, opts) do
{:ok, conn} ->
{:ok, conn} = :efirebirdsql_protocol.begin_transaction(false, conn)
{:ok, %__MODULE__{conn: conn}}
{:error, number, reason, _conn} ->
{:error, %Firebirdex.Error{number: number, reason: reason}}
Expand Down
2 changes: 1 addition & 1 deletion mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ defmodule Firebirdex.Mixfile do
[
{:db_connection, "~> 2.0"},
{:decimal, "~> 1.6"},
{:efirebirdsql, "~> 0.5.8"},
{:efirebirdsql, "~> 0.5.9"},
{:ex_doc, ">= 0.0.0", only: :dev, runtime: false}
]
end
Expand Down
2 changes: 1 addition & 1 deletion mix.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"db_connection": {:hex, :db_connection, "2.0.2", "440c05518b0bdca0469dafaf45403597430448c1281def14ef9ccaa41833ea1e", [:mix], [{:connection, "~> 1.0.2", [hex: :connection, repo: "hexpm", optional: false]}], "hexpm"},
"decimal": {:hex, :decimal, "1.6.0", "bfd84d90ff966e1f5d4370bdd3943432d8f65f07d3bab48001aebd7030590dcc", [:mix], [], "hexpm"},
"earmark": {:hex, :earmark, "1.3.1", "73812f447f7a42358d3ba79283cfa3075a7580a3a2ed457616d6517ac3738cb9", [:mix], [], "hexpm"},
"efirebirdsql": {:hex, :efirebirdsql, "0.5.8", "d71b2547a94c00c42be42ecacb9510fb6fd7d066065d67ec1e2c58b21d818166", [:rebar3], [], "hexpm"},
"efirebirdsql": {:hex, :efirebirdsql, "0.5.9", "41f6df2b107c63162cf50f53f4e8cd17cc3ff8efe260892ea916445b2230aa05", [:rebar3], [], "hexpm"},
"ex_doc": {:hex, :ex_doc, "0.19.3", "3c7b0f02851f5fc13b040e8e925051452e41248f685e40250d7e40b07b9f8c10", [:mix], [{:earmark, "~> 1.2", [hex: :earmark, repo: "hexpm", optional: false]}, {:makeup_elixir, "~> 0.10", [hex: :makeup_elixir, repo: "hexpm", optional: false]}], "hexpm"},
"makeup": {:hex, :makeup, "0.8.0", "9cf32aea71c7fe0a4b2e9246c2c4978f9070257e5c9ce6d4a28ec450a839b55f", [:mix], [{:nimble_parsec, "~> 0.5.0", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm"},
"makeup_elixir": {:hex, :makeup_elixir, "0.13.0", "be7a477997dcac2e48a9d695ec730b2d22418292675c75aa2d34ba0909dcdeda", [:mix], [{:makeup, "~> 0.8", [hex: :makeup, repo: "hexpm", optional: false]}], "hexpm"},
Expand Down
2 changes: 1 addition & 1 deletion test/firebirdex_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ defmodule FirebirdexTest do
)", [])
{:ok, %Firebirdex.Result{} = result} = Firebirdex.query(conn,
"SELECT * from foo", [])
assert result.rows == [[]]
assert result.rows == []

end
end

0 comments on commit 0846b32

Please sign in to comment.