Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pocock/cmake boost #4

Open
wants to merge 70 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
44ca3de
kmsicecandidate: Don't set VALID when mDNS cannot resolve
j1elo Jan 23, 2020
5ef161f
kmsrtpendpoint: Correct parsing of "a=rtcp" attributes
j1elo Jan 23, 2020
3b444e0
Fix stunServerPort default value usage
prlanzarin Mar 10, 2020
3e695df
webrtcendpoint: fix unsigned printf modifiers (%u)
j1elo Mar 17, 2020
d58731d
webrtcendpoint: unify log messages
j1elo Mar 17, 2020
61435ac
webrtcendpoint minor: print TURN type in debug log
j1elo Apr 6, 2020
7421529
kmsicenicecandidate minor: print candidate on add error
j1elo Apr 22, 2020
ce2dcfd
kmswebrtcsession: add_ice_candidate minor refactor & logging
j1elo Apr 22, 2020
2f962a4
Bump development version to 6.13.2-0kurento1
j1elo Apr 22, 2020
a4c9f35
webrtcendpoint: fix leaked sockets from libnice breaking change
j1elo Apr 27, 2020
af03fc0
Reduce default log levels for WebRTC-related modules
j1elo May 22, 2020
c6e312b
recorder minor: better message when caps fail match
j1elo May 25, 2020
cfae66b
recorder: review API doc and clarify some paragraphs
j1elo Jun 9, 2020
ec32f39
tests/webrtcendpoint: print session ID and ICE candidate
j1elo Jun 10, 2020
8fe50d8
tests/webrtcendpoint: use a HashMap to store gathered addresses
j1elo Jun 15, 2020
143fccb
tests/webrtcendpoint: re-enable all tests that were commented out
j1elo Jun 15, 2020
0745ce7
WebRtcEndpoint: rewrite docs for externalAddress, discourage using it
j1elo Jun 16, 2020
f370d6b
WebRtcEndpoint: document the 'pemCertificate' settings
j1elo Jun 16, 2020
d14364f
All: use GST_STR_NULL instead of explicit NULL check for strings
j1elo Jun 16, 2020
a0dba8b
Prepare release 6.14.0-0kurento1
j1elo Jun 16, 2020
9bdb3cb
Prepare for next development iteration
j1elo Jun 18, 2020
9230e5c
webrtcendpoint: improve safe TURN logging string
j1elo Jun 26, 2020
741b5f1
recorder: change docs HTTP PUT -> POST & improve error messages
j1elo Jul 23, 2020
f37243c
Fix incorrect cropping in AlphaBlending element (#24)
t-mullen Aug 3, 2020
17e0182
Add externalIPv4/externalIPv6 configs and API methods for them
prlanzarin Sep 10, 2020
6c34c1e
webrtcendpoint: tests for externalIPv4, externalIPv6
j1elo Sep 11, 2020
674516f
webrtcendpoint: rewrite docs for externalAddress, externalIPv4, exter…
j1elo Sep 11, 2020
82cebc8
webrtcendpoint: deprecate externalAddress
j1elo Sep 11, 2020
ea5813a
Merge pull request #27 from prlanzarin/6140-extipv4-6
j1elo Sep 11, 2020
2137fb2
minor, cmake: "Warnings are Errors" exception samples
j1elo Oct 9, 2020
018e191
Replace GST_PAD_PROBE_INFO_* macros with type-checked getters
j1elo Oct 9, 2020
372bd58
PlayerEndpoint API: document networkCache (RTSP buffer length)
j1elo Oct 9, 2020
fb0cbce
minor, recorder: reorganize code and add comments
j1elo Oct 9, 2020
29fad84
webrtc: fix test_not_enough_ports for libnice 0.1.18
j1elo Oct 22, 2020
443f3dc
fixup! minor, recorder: reorganize code and add comments
j1elo Oct 22, 2020
c5e1651
recorder: improve a/v sync compensating gaps in audio timestamps
j1elo Oct 22, 2020
3130845
webrtc: log effective STUN/TURN server, network interfaces, ICE cand
j1elo Oct 22, 2020
bbd1c7c
debian: update versions of Kurento dependencies
j1elo Oct 22, 2020
6bf0de2
cmake: add "-Wno-error=unused-function" for tests
j1elo Oct 23, 2020
aaf3774
minor: proper example IPs and comments on TURN
j1elo Nov 3, 2020
fdbe294
Prepare release 6.15.0-0kurento1
j1elo Nov 3, 2020
02fdd64
Prepare for next development iteration
j1elo Nov 6, 2020
25de1c7
Update all dependency versions to 6.15.1
j1elo Nov 6, 2020
4e23ff0
Update URLs to latest Kurento doc versions in ReadTheDocs
j1elo Nov 9, 2020
904d229
Fail when IPv6 is not available, avoid getting stuck
j1elo Dec 4, 2020
968a03c
recorder: allow duplicate STOP requests (don't fail)
j1elo Dec 9, 2020
b4f3d1e
player, recorder: add notes about special chars (@, :) + text review
j1elo Jan 8, 2021
bef5735
recorder doc minor: improve some lines
j1elo Jan 29, 2021
f4fe607
ALL: change kms-api dependency range to the current release version
j1elo Jan 29, 2021
c0da4da
API: clearer explanations of RecvBandwidth, SendBandwidth
j1elo Feb 5, 2021
fe6092b
Add niceAgentIceTcp configuration option and API methods for it (#26)
prlanzarin Feb 19, 2021
fbaddbc
recorder: add config to choose gaps fix method (#31)
j1elo Feb 19, 2021
a29b64e
Prepare release 6.16.0-0kurento1
j1elo Feb 26, 2021
8c3c0ba
Prepare for next development iteration
j1elo Mar 3, 2021
d12b82b
recorder: extend doc of GapsFixMethod
j1elo Mar 5, 2021
9327a89
cmake: remove unused var DEBUG_MEDIASET
j1elo Apr 15, 2021
83db205
player: rewrite docs of useEncodedMedia
j1elo Apr 23, 2021
9d27dcf
webrtc: check STUN & TURN before printing warning message
j1elo May 5, 2021
1b08cb5
webrtc: remove unused macros; improve error check
j1elo May 5, 2021
b046a0f
webrtc niceagent: push signal emissions to owned context thread
j1elo May 6, 2021
c82305f
webrtc, rtp: replace G_MAXUINT16 with 65535
j1elo Jun 14, 2021
bee3281
rtp: move max/min port logic to BaseRtpEndpoint
j1elo Jun 14, 2021
c017eb2
webrtc: extend doc for gatherCandidates() method
j1elo Jun 14, 2021
fe060fc
webrtc: rename JSON-RPC streamID, componentID to streamId, componentId
j1elo Jul 8, 2021
bfc4064
webrtc minor: say "ICE" instead of "ice"
j1elo Jul 8, 2021
1fd17d9
Revert "webrtc: rename JSON-RPC streamID, componentID to streamId, co…
j1elo Jul 12, 2021
810fd49
webrtc: deprecate JSON-RPC streamID, componentID for streamId, compon…
j1elo Jul 12, 2021
0b6993e
fixup! webrtc: deprecate JSON-RPC streamID, componentID for streamId,…
j1elo Jul 13, 2021
7a1ae52
cmake: remove KURENTO_DOT_DIR, make GST_DEBUG_DUMP_DOT_DIR dir to work
j1elo Aug 2, 2021
7550a74
CMakeLists.txt: explicitly list the Boost libraries required for linking
dpocock Aug 31, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
kmsicenicecandidate minor: print candidate on add error
  • Loading branch information
j1elo committed Apr 22, 2020
commit 7421529046894ff5ead8de535d877a0941e49c15
3 changes: 2 additions & 1 deletion src/gst-plugins/webrtcendpoint/kmsiceniceagent.c
Original file line number Diff line number Diff line change
@@ -518,7 +518,8 @@ kms_ice_nice_agent_add_ice_candidate (KmsIceBaseAgent * self,
if (nice_agent_set_remote_candidates (nice_agent->priv->agent,
nice_cand->stream_id, nice_cand->component_id, candidates) < 0) {
GST_WARNING_OBJECT (self,
"[AddIceCandidate] Error in libnice, remote candidate NOT added");
"[AddIceCandidate] Error in libnice, adding remote: '%s'",
kms_ice_candidate_get_candidate (candidate));
ret = FALSE;
} else {
ret = TRUE;