refactor(portmapper)!: non-global metrics collection #20
+94
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/net-tools/pr/20/docs/net_tools/ Last updated: 2025-04-16T11:01:03Z |
Frando
changed the title
Frando
changed the title
| @@ -73,16 +75,18 @@ pub(super) struct CurrentMapping<M = super::mapping::Mapping> { | |||
| /// Waker to ensure this is polled when needed. | |||
| #[debug(skip)] | |||
| waker: Option<std::task::Waker>, | |||
| metrics: Arc<Metrics>, | |||
There was a problem hiding this comment.
why do we have to store it in an Arc?
There was a problem hiding this comment.
We don't have to. My thinking was that the clones are much smaller then. The metrics structs are usually quite large (200-400bytes, 24bytes for each counter) vs. 8 bytes for an Arc. But the Arc has the cost of a pointer derefence for each metric usage. Not sure what is better tbh.
dignifiedquire
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Needed for n0-computer/iroh#3262
Updates
iroh-metricsto 0.33, and makes the metrics collection non-global. Metrics are now collected per portmapper service.Breaking Changes
portmapper::metrics::Metricsnow implementsMetricsGroupfrom[email protected], and no longer implementsMetricfrom[email protected].Notes & open questions
Change checklist