Skip to content

deps(iroh-net): Upgrade igd-next, remove hyper 0.14 #2804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

flub
Copy link
Contributor

@flub flub commented Oct 15, 2024

Description

This finally removes the last use of a pre-1.0 hyper version,
eliminating our duplicate hyper dependencies.

Breaking Changes

None

Notes & open questions

Closes #1863.

Change checklist

  • Self-review.
  • [ ] Documentation updates following the style guide, if relevant.
  • [ ] Tests if relevant.
  • [ ] All breaking changes documented.

This finally removes the last use of a pre-1.0 hyper version,
eliminating our duplicate hyper dependencies.

Closes #1863.
Copy link

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2804/docs/iroh/

Last updated: 2024-10-15T09:13:02Z

Copy link
Member

@matheus23 matheus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The world with clean dependencies
image

@flub flub added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 5e40fe1 Oct 15, 2024
25 of 27 checks passed
@flub flub deleted the flub/hyper-1-finally branch October 15, 2024 10:40
Arqu added a commit that referenced this pull request Oct 28, 2024
@link2xt
Copy link
Contributor

link2xt commented Oct 31, 2024

This surprisingly broke compatibility to iroh-relay 0.25.0: chatmail/core#6133

@link2xt
Copy link
Contributor

link2xt commented Oct 31, 2024

Not so surprising anymore: apparently iroh works on networks with UPNP, but does not work on networks without UPNP (including GithHub Actions).
And igd-next is an UPNP implementation.
I am commenting more in chatmail/core#6133 (comment) and opened #2876

matheus23 pushed a commit that referenced this pull request Nov 14, 2024
## Description

This finally removes the last use of a pre-1.0 hyper version,
eliminating our duplicate hyper dependencies.

## Breaking Changes

None

## Notes & open questions

Closes #1863.


## Change checklist

- [x] Self-review.
- ~~[ ] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.~~
- ~~[ ] Tests if relevant.~~
- ~~[ ] All breaking changes documented.~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Upgrade all dependencies to hyper 1.0
3 participants