refactor: push metrics at regular intervals #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-n0des/pr/44/docs/iroh_n0des/ Last updated: 2025-10-20T13:17:57Z |
Frando
force-pushed
the
Frando/metrics-improvements
branch
from
34bb96f to
9464c2f
Compare
Frando
changed the title
Arqu
reviewed
Oct 22, 2025
| /// Environment variable name for the simulation session ID. | ||
| pub const ENV_TRACE_SESSION_ID: &str = "N0DES_SESSION_ID"; | ||
|
|
||
| const METRICS_INTERVAL: Duration = Duration::from_secs(1); |
There was a problem hiding this comment.
this is way to aggressive, pls set it to 10 or 15s which is the default scrape interval used elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking Changes
Notes & open questions
Change checklist