Skip to content

Feat/homeworship video upload#186

Open
wannabeing wants to merge 3 commits intomainfrom
feat/homeworship-video-upload
Open

Feat/homeworship video upload#186
wannabeing wants to merge 3 commits intomainfrom
feat/homeworship-video-upload

Conversation

@wannabeing
Copy link
Member

수정

  • 가정예배 영상 업로드 기능 추가
  • 모바일 디자인 간단수정
  • 환경변수 수정/추가
CLOUDFLARE_REQ_IMG_URL // CLOUDFLARE_REQ_URL 수정
CLOUDFLARE_REQ_VIDEO_URL // 추가

참고

@netlify
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for myungmoon-luv ready!

Name Link
🔨 Latest commit 7f0dc47
🔍 Latest deploy log https://app.netlify.com/sites/myungmoon-luv/deploys/66ed16c63a5ac600089359d7
😎 Deploy Preview https://deploy-preview-186--myungmoon-luv.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for myungmoon-admin failed.

Name Link
🔨 Latest commit 7f0dc47
🔍 Latest deploy log https://app.netlify.com/sites/myungmoon-admin/deploys/66ed16c6aaf45200086f9e1d

: "";

// 2. 비디오 파일 업로드 처리
const contentVideo = videoFile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런식으로 다 삼항연산자로 변수에 넣는 것보다 함수로 만들어서 거기서 반환시키는게 가독성이 더 좋을 것 같아요

<p>이름</p>
<input {...register("name")} className="rounded-md border border-gray-200 px-2 py-1" />
<p className="text-sm md:text-base">이름</p>
<input
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

input 들이 비슷한데 컴포넌트로 분리는 어떤가요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants