2025 methodology text #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarino
approved these changes
May 22, 2024
There was a problem hiding this comment.
From a quick scroll through, this looks good to me. I’ve tweaked the homepage banner layout, and moved the methodology page table of contents into its own partial.
I think the next step here is for @struan to get this deployed to staging, for CEUK to review.
Hard-coded at the moment, based on `question.code`.
Always filter by year
struan
force-pushed
the
2025_methodology_text
branch
from
673a33f to
7710bf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of: #643
Note: about the "Announcement" component I have included two versions, the 2022 one, which I think is a bit hard to scan. The other versions is a two column layout one(not a huge fan of the grey box below the main content so I wouldn't mind getting rid of that). Let me know which one you prefer and I'll erase the one.