Skip to content

CFR ODD_FIR is always written as zero #395

Open

Description

@dmitrymmm

SetFIRCoefficients ends with

const uint16_t Filt_N = 32;
...
WriteRegister(ODD_FIR, Filt_N % 2);

Filt_N is a local constant, so the odd flag is unconditionally 0 regardless of the count parameter, which is only used in an assert. Configure relies on this call for the register - // WriteRegister(ODD_FIR, fir.coefficientsCount % 2); // set in SetFIRCoefficients - so nothing ever programs it correctly. Configure also writes the FIR tap parity into ODD_CFR, the CFR order register that UpdateHannCoeff already programs from cfr.order.

Activity

  1. dmitrymmm commented on Aug 3, 2026

    @dmitrymmm
    ContributorAuthor

    Fix submitted in #376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions