Support transform for field assignments #1
+33
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current implementation of
+++
, the result of macro expansion for field assignments looks somewhat problematic:(The form
(set! (fence.core/dot obj -x) 42)
will in turn be expanded to(set! (aget obj "x") 42)
, which is a bad form.)This PR enables
+++
macro to deal with field assignment forms appropriately.Also, a new macro
fence.core/set!
is provided as a shorthand for the combination of+++
andset!
: