Skip to content

Conversation

@xuelianhan007
Copy link
Contributor

Description

Made an improvement on deploy tips

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • CI/CD or documentation update (changes to CI/CD pipeline or documentation)

Self Checklist

  • I ensured that I are not pushing configuration files containing sensitive information such as testing keys.
  • I ensured that large PR is avoided, Consider splitting if there are more than 500 line changes, In addition to line count, also consider the number of files being affected, An ideal amount is less than 10, 25-30 is generally too large with the exception of library upgrades, refactors, etc.
  • I ensured that If the PR is inevitably large, a short PR review meeting or discuss with reviewers will be organized.
  • I ensured that If the PR is to resolve a blocker, do not make unrelated changes in the same PR e.g. formatting changes, to minimize review time.
  • I ensured that PR is focused
  • I ensured that context was given in the PR description, Include a clear description of the changes
  • I ensured that related github issues are linked, Include screenshots if this will make the context clearer for the reviewer
  • I ensured that "work in progress" or "hold" labels are removed
  • I ensured that adherence to style guidelines
  • I ensured that feature flag is applied if needed
  • I ensured that follow secure development practices
  • I ensured that no secrets or sensitive data have been committed or logged
  • I ensured that no hardcoded values that may change depending on environment (these should be configured dynamically e.g. through environment variables, from the db etc)

@xuelianhan007 xuelianhan007 requested a review from a team as a code owner January 6, 2026 02:48
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID
spring-web 6.1.14 Medium 6.1.21 GHSA-6r3c-xf4w-jxjm
nimbus-jose-jwt 9.37.3 Medium 9.37.4 GHSA-xwmg-2g98-w7v9
commons-lang3 3.14.0 Medium 3.18.0 GHSA-j288-q9x7-2f5v
esbuild 0.24.2 Medium 0.25.0 GHSA-67mh-4wv8-2f99

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2026

Quality Gate Failed Quality Gate failed for 'kraken_nodejs'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants