Skip to content

fix(portal): resolved the issue requiring double-click when setting source inputs #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xuelianhan007 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(portal): resolved the issue requiring double-click when setting source inputs #864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f31251
Fixed the issue requiring double-click when setting the source input …
xuelianhan007 Dec 18, 2025
ff6f620
removed debug logs
xuelianhan007 Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions kraken-app/kraken-app-portal/src/pages/NewAPIMapping/components/RequestItem/SourceInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ export function SourceInput({
const isFocused = useMemo(
() =>
rightSide === EnumRightType.AddSonataProp &&
isEqual(item, rightSideInfo?.previousData),
[rightSide, item, rightSideInfo?.previousData]
isEqual(item.id, rightSideInfo?.previousData?.id),
[rightSide, item.id, rightSideInfo?.previousData?.id]
);

const handleChange = (changes: { [field in keyof typeof item]?: any }) => {
Expand All @@ -42,6 +42,12 @@ export function SourceInput({
}

setRequestMapping(newRequest);
if (isFocused && rightSideInfo) {
setRightSideInfo({
...rightSideInfo,
previousData: newRequest[index],
});
}
};
return (
<Flex className={styles.flexColumn} gap={4}>
Expand Down
6 changes: 6 additions & 0 deletions kraken-app/kraken-app-portal/src/pages/NewAPIMapping/components/RequestItem/TargetInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ export function TargetInput({
}

setRequestMapping(newRequest);
if (isFocused && rightSideInfo) {
setRightSideInfo({
...rightSideInfo,
previousData: newRequest[index],
});
}
};
return (
<Flex className={styles.flexColumn} gap={4}>
Expand Down
1 change: 0 additions & 1 deletion kraken-app/kraken-app-portal/src/pages/NewAPIMapping/components/RequestItem/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,6 @@ const RequestItem = ({ item, index }: Props) => {
setRequestMapping(newRequest);
}
}, [continuousInput]);

return (
<div
className={clsx([
Expand Down
1 change: 0 additions & 1 deletion kraken-app/kraken-app-portal/src/pages/NewAPIMapping/components/ResponseItem/SourceInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ export function SourceInput({
const id = `${index}-${item?.name}`;
const isFocused =
rightSide === EnumRightType.AddSellerResponse && activeResponseName === id;

return (
<Flex className={styles.flexColumn} gap={4}>
{item.source ? (
Expand Down
1 change: 0 additions & 1 deletion kraken-app/kraken-app-portal/src/pages/NewAPIMapping/components/ResponseItem/TargetInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ export function TargetInput({

const isFocused =
rightSide === EnumRightType.SonataResponse && activeSonataResponse === id;

return (
<Flex className={styles.flexColumn} gap={4}>
{item.target ? (
Expand Down
1 change: 0 additions & 1 deletion kraken-app/kraken-app-portal/src/pages/NewAPIMapping/components/RightAddSellerProp/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ const RightAddSellerProp = ({ onSelect }: Readonly<Props>) => {
styles.treeValue
);
}, [sellerApi]);

const { handleAddProp, collapseItems } = useCommonAddProp({
selectedProp,
rightSideInfo,
Expand Down
3 changes: 1 addition & 2 deletions kraken-app/kraken-app-portal/src/pages/NewAPIMapping/components/RightAddSonataProp/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ const RightAddSonataProp = ({
styles.treeValue
);
}, [correctSpec]);

const { handleAddProp, collapseItems } = useCommonAddProp({
selectedProp,
rightSideInfo,
Expand All @@ -98,7 +97,7 @@ const RightAddSonataProp = ({
setSelectedProp,
onSelect,
});

return (
<Flex
vertical
Expand Down
2 changes: 1 addition & 1 deletion kraken-app/kraken-app-portal/src/pages/NewAPIMapping/components/SonataPropMapping/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ const SonataPropMapping = ({ list, title }: Readonly<Props>) => {
setRightSideInfo(undefined);
}

const notEmptyList = !!list.length
const notEmptyList = !!list.length;
return (
<Flex gap={16}>
<div className={styles.sonataPropMappingWrapper}>
Expand Down
Loading