Branch And Updated column added to Web panel #52 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes were inspired by PR #9 which was closed by author @treymarc. This disables the ApprovalFunctionTest, because junit was failing due to ClassNotFoundException looking for UserKeyStore. This will likely require implementing some kind of compatibility layer due to the User API changes between JIRA 5 and 6. Some plugins and dependencies have also been updated to their latest versions.
update example user creation to reflect gerrit api v2.10
* Move dashboard link above the table header. * Left align text and headers * More readable link text for dashboard
In case of a misconfigured app-data file system level access permissions it'll throw an unreadable exception stack trace to the browser screen. This change makes it fail gracefully and add a meaningful message with details to the log.
Treat and log exception when trying to add a Private Key.
Improve webpanel readability
Add support for viewing gerrit panel in JIRA Agile Details Panel
…to master * 'master' of git://github.com/p00by/jira-gerrit-plugin: Adds support for jira 7 Conflicts: pom.xml src/main/java/com/meetme/plugins/jira/gerrit/data/dto/GerritApproval.java src/main/java/com/meetme/plugins/jira/gerrit/tabpanel/GerritReviewsTabPanel.java
As of 3.0, the code now only supports JIRA 7+ This is because of a breaking API change in the JIRA 7 update.
Support for multiple issue keys (e.g. issues moved between projects)
Text for screen readers was missing "overflow: hidden;" property and was thus rendered 9999px to the right. fixes #45
Fix rendering of side panel
Add optional whitelist for holding projects, that use gerrit.
The statuses can be extended via Gerrit plugins, in which case we would throw an exception and fail to show any changes for the issue. java.lang.IllegalArgumentException: No enum constant com.meetme.plugins.jira.gerrit.data.dto.GerritChange.Status.INTEGRATING at java.lang.Enum.valueOf(Enum.java:238) at com.meetme.plugins.jira.gerrit.data.dto.GerritChange$Status.valueOf(GerritChange.java:35) at com.meetme.plugins.jira.gerrit.data.dto.GerritChange.fromJson(GerritChange.java:90) at com.sonyericsson.hudson.plugins.gerrit.gerritevents.dto.attr.Change.<init>(Change.java:97) at com.meetme.plugins.jira.gerrit.data.dto.GerritChange.<init>(GerritChange.java:52) at com.meetme.plugins.jira.gerrit.data.IssueReviewsImpl.getReviewsFromGerrit(IssueRev There's no need to hard-code these statuses as enums, as the rest of the plugin operates on them as strings anyways.
Remove hard-coded Gerrit statuses
This will enable caching in a clustered environment, such as Jira Data Center.
way this support is indicated. New changes are added as per [1]. [1] https://developer.atlassian.com/platform/marketplace/dc-apps-submitting-your-app/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For triaging defects related check-ins in Gerrit, we want Branch and Updated field added to the Web Panel view.