Skip to content

update python and use randbytes+seed for sharehash #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PaulaScharf wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update python and use randbytes+seed for sharehash #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .docker/Dockerfile.dev.api
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:3.8.14-slim-buster
FROM python:3.9-slim-buster

RUN mkdir /badgr_server
WORKDIR /badgr_server
Expand Down
4 changes: 2 additions & 2 deletions .docker/Dockerfile.prod.api
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Best practies taken from here: https://snyk.io/blog/best-practices-containerizing-python-docker/

# ------------------------------> Build image
FROM python:3.8.14-slim-buster as build
FROM python:3.9-slim-buster as build
RUN apt-get update
RUN apt-get install -y default-libmysqlclient-dev \
python3-dev \
Expand All @@ -20,7 +20,7 @@ COPY requirements.txt .
RUN pip install -r requirements.txt

# ------------------------------> Final image
FROM python:3.8.14-slim-buster
FROM python:3.9-slim-buster
RUN apt-get update
RUN apt-get install -y default-libmysqlclient-dev \
python3-cairo \
Expand Down
4 changes: 3 additions & 1 deletion apps/backpack/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import os
import binascii
import random
from collections import OrderedDict

import cachemodel
Expand Down Expand Up @@ -76,7 +77,8 @@ def published(self):
@published.setter
def published(self, value):
if value and not self.share_hash:
self.share_hash = str(binascii.hexlify(os.urandom(16)), 'utf-8')
random.seed(a=self.entity_id)
self.share_hash = str(binascii.hexlify(random.randbytes(16)), 'utf-8')
elif not value and self.share_hash:
self.publish_delete('share_hash')
self.share_hash = ''
Expand Down