Enable site diffraction viewer#2113
Merged
Merged
Conversation
matyson
marked this pull request as draft
May 28, 2026 14:36
| if path: | ||
| fpath, img = HWR.beamline.detector.get_actual_file_path(path, img_num) | ||
| HWR.beamline.collect.adxv_notify(fpath, img) | ||
| HWR.beamline.collect.site_diffraction_viewer(fpath, img) |
Member
There was a problem hiding this comment.
As I mentioned in the other PR, I would just call it it display_image or similair. Then each site can decide what to do in their collect sub class, its understood that it can be site specific.
matyson
force-pushed
the
mb-enable-siteviewer
branch
from
June 4, 2026 08:56
07fb81a to
2b694da
Compare
matyson
marked this pull request as ready for review
June 4, 2026 09:05
- change hwo collect method call to site_diffraction_viewer - prevent opening blank page when braggy is not enabled
marcus-oscarsson
force-pushed
the
mb-enable-siteviewer
branch
from
June 11, 2026 15:17
2b694da to
2106ebd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling #1616 if accepted
hw.beamline.collect.adxv_notifycall to.site_diffraction_viewer