docs: add architecture guide to developer docs#1624
Conversation
2e01812 to
c13c8e5
Compare
|
Thanks alot, a very nice initiative :) !. Could you add the rendered versions of the images, we don't currently have a |
| # Allow GitHub-style fenced blocks like ```mermaid to be parsed as | ||
| # ``{mermaid}`` directives so diagrams render in Sphinx/RTD. | ||
| myst_fence_as_directive = [ | ||
| "mermaid", | ||
| ] | ||
|
|
|
|
||
| subgraph "Application Layer - mxcubeweb" | ||
| UI[React Frontend] | ||
| API[FastAPI Backend] |
There was a problem hiding this comment.
Looks pretty good in general, this should be Flask though and not FastAPI :) I think there one or two more instances of FastAPI. But it otherwise looks quite correct
There was a problem hiding this comment.
Thanks for catching that. This document was generated last year so maybe those were legacy elements ? Anyway i replaced the fastAPI instances in this doc :)
b36d3b3 to
320d147
Compare
| subgraph "Application Layer - mxcubeweb" | ||
| UI[React Frontend] | ||
| API[Flask Backend] | ||
| WS[WebSocket Server] |
There was a problem hiding this comment.
| WS[WebSocket Server] |
There was a problem hiding this comment.
I would simply remove the WS WebSocket Server and perhaps include it in API[Flask Backend]. Or make another box around the two.
|
I went through this again and it does for the most part look correct and I think it can be really useful to get an over view of the project. But it should be taken with a pinch of salt its not really accurate but correct on a conceptual level. I had one more remark on the graph, and it would be great if you could run the |
|
Maybe we could add some remark that the diagrams have been generated based on the existing codebase and written with assist of a coding agent. Just so that it does not seem authorative, it could help us avoid some potential confusion in the future in case someone were to look at an outdated by then diagram :) |
|
Yes we can add such a comment. But all documentation we add should be revived and accurate for whatever purpose it has. So adding a sort of disclaimer at the same time seems a bit contradictory, but I can understand that it helps. In that case, perhaps write something like: This documentation was partly generated automatically and is meant to give an architectural overview and idea of the concepts involved and may lack or be some detail. |
Yes, that's more akin to something I had in mind. I've just overemphasized the part regarding outdateness, which is quite hard to avoid :) |
|
@hedi-tej: We are ready to merge this one if you just look at the linting error, I guess its something small ? |
|
Hello all, Thank you for your feedback. I just returned from vacation.
Best regards, |
9c2c68f to
cf55aa9
Compare
|
Well done, thanks. I think it will be quite useful for new developers ! |
|
Sorry for taking sometime before merging. Thanks for the nice work ! |


Summary