Add developer documentation for the Harvester integration#1623
Open
jbflo wants to merge 1 commit into
Open
Conversation
jbflo
force-pushed
the
jb-harvester-docs
branch
3 times, most recently
from
53d47ee to
22c0807
Compare
jbflo
force-pushed
the
jb-harvester-docs
branch
2 times, most recently
from
971c9cb to
aa3899e
Compare
marcus-oscarsson
force-pushed
the
jb-harvester-docs
branch
from
aa3899e to
a26ade9
Compare
beteva
reviewed
Jul 9, 2026
Comment on lines
+442
to
+443
| The resulting tuple `(phiy_offset, centringFocus, centringTableVertical)` is | ||
| passed directly to `Diffractometer.start_harvester_centring()`. |
Member
There was a problem hiding this comment.
could you, please, actualise this with the latest version (motor names, methods ...)
beteva
requested changes
Jul 9, 2026
beteva
left a comment
beteva
left a comment
Member
There was a problem hiding this comment.
Well done.
Few incorrect names and methods to be changed.
jbflo
force-pushed
the
jb-harvester-docs
branch
2 times, most recently
from
5837237 to
88df9f5
Compare
Member
Author
Done ! |
beteva
reviewed
Jul 9, 2026
| SC->>CDH2: loadSampleFromHarvester(pin_cleaning) [exporter cmd] | ||
| CDH2-->>SC: Pin mounted | ||
| HM->>MD: move_motors(kappa, kappa_phi, phi, phiy + drift_x) | ||
| HM->>MD: centringFocus.set_value_relative(drift_z) |
Member
There was a problem hiding this comment.
could you, please, actualise this with the latest version (motor names, methods ...)
Member
Author
There was a problem hiding this comment.
yes Fixed, still had a few missing.
Covers the CrystalDirect Harvester 3 (CDH3) integration at MASSIF-1: architecture, hardware objects (Harvester, HarvesterMaintenance, EMBLFlexHarvester, HarvesterMockup), harvester states, queue workflow with decision flowchart, look-ahead harvesting, two-step pin calibration, sample centring offset calculation, configuration examples, main methods reference, and MXCuBE-Web integration including UI controls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit late, but better late than never.
Add developer documentation for the Harvester integration
Summary
docs/source/dev/harvester.mdcovering the CrystalDirect Harvester 3(CDH3) integration developed for MASSIF-1 at ESRF/EMBL
index.rst)What is covered
EMBLFlexHarvester, HarvesterMockup)
Notes
Requires
sphinxcontrib-mermaidfor the diagrams (pip install sphinxcontrib-mermaidin the docs environment)document the Harvester code for EMBL/HTX and ESRF maintenance purposes.