Multiple minor fixes #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 25, 2022 10:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy 👋
I was working on a project two years ago where we needed to do some work related to uritemplating and at that time we ended up forking this library due to a couple of limitations. Those limitations are:
I don't know whether all or some of these "problems" we were having a were purely because of limitations in the library or because our use case didn't fully meet the spec. Nonetheless I now have use for these "fixes" again and decided to open this PR with the fixes so that you can review it and decide whether it is something you would want to add to the library. The three fixes are independent commits so it should be straight-forward to review if each of them make sense. Open to discussing any of it as well.
Cheers
Jonas