feat(limits): emit limit webhook events from LimitsService - #864
Merged
Conversation
Add limit event types (LIMIT_UPDATED, LIMIT_EXCEEDED, LIMIT_WARNING) to WebhookEventType enum and corresponding emitter methods to WebhookEventEmitterService. LimitsService already bridged internal events to the webhook emitter but the target methods and event types did not exist. This commit adds them and makes the webhook emitter injection @optional() with safe optional chaining so the service remains functional without webhooks. Closes mux-labs#770 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LIMIT_UPDATED,LIMIT_EXCEEDED,LIMIT_WARNINGevent types toWebhookEventTypeenumemitLimitUpdated,emitLimitExceeded,emitLimitWarningmethods toWebhookEventEmitterServiceWebhookEventEmitterServiceinjection@Optional()inLimitsServicewith safe optional chaining so the service remains functional in test isolation without webhooksCloses #770
Test plan
emitLimitUpdatedis called when limits are created or changed viasetLimits()emitLimitExceededis called when per-transaction or daily limits are exceededemitLimitWarningis called when daily usage approaches 80% threshold🤖 Generated with Claude Code