-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#166: Added support for the interface name in the config file #167
base: main
Are you sure you want to change the base?
Conversation
Hello @glaslos, Thank you for your feedback! I’ve made the necessary changes and am looking forward to contributing further to this project. Please feel free to let me know if any additional adjustments are needed, I’d be happy to make them. Thanks again, |
Hello @glaslos, Thank you for your feedback! I’ve made the necessary changes and am looking forward to contributing further to this project. Please feel free to let me know if any additional adjustments are needed, I’d be happy to make them. Thanks again, |
Hi @glaslos, |
Now the last change missing is in the Makefile |
Hi @glaslos , Thank you, |
@@ -30,7 +30,7 @@ clean: | |||
rm -rf bin/ | |||
|
|||
run: build | |||
sudo bin/server -i eth0 | |||
sudo bin/server -c config.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not necessary to define the config path. Also I don't think this will work since the config file is in a folder.
Hey @glaslos,
Reffering to issue #166
I've made the necessary changes including adding new field to the configuration file for specifying the interface name.
Here’s how you can use the command:
Example use case:
sudo bin/server -i wlan0
By default, it will use
eth0
.Additionally, I've included instructions for installing and running the project on Fedora. Since the
bin/server
command requires sudo privileges, I’ve also tried upgrading the README.md file to reflect these changes accordingly.I would greatly appreciate your feedback on any changes or further modifications needed, I will be glad to do so!
Thank you,
Tank0nf.