Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#166: Added support for the interface name in the config file #167

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tank0nf
Copy link

@tank0nf tank0nf commented Jan 29, 2025

Hey @glaslos,

Reffering to issue #166
I've made the necessary changes including adding new field to the configuration file for specifying the interface name.
Here’s how you can use the command:

sudo bin/server -i <interface name>

Example use case: sudo bin/server -i wlan0

By default, it will use eth0.

Additionally, I've included instructions for installing and running the project on Fedora. Since the bin/server command requires sudo privileges, I’ve also tried upgrading the README.md file to reflect these changes accordingly.

I would greatly appreciate your feedback on any changes or further modifications needed, I will be glad to do so!
Thank you,
Tank0nf.

@tank0nf tank0nf changed the title Added support for the interface name in the config file #166 #166: Added support for the interface name in the config file Jan 29, 2025
Makefile Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
config/config.yaml Outdated Show resolved Hide resolved
glutton.go Outdated Show resolved Hide resolved
glutton.go Outdated Show resolved Hide resolved
glutton.go Outdated Show resolved Hide resolved
glutton.go Outdated Show resolved Hide resolved
@tank0nf
Copy link
Author

tank0nf commented Jan 31, 2025

Hello @glaslos,

Thank you for your feedback! I’ve made the necessary changes and am looking forward to contributing further to this project.

Please feel free to let me know if any additional adjustments are needed, I’d be happy to make them.

Thanks again,
Tank0nf.

Makefile Outdated Show resolved Hide resolved
glutton.go Outdated Show resolved Hide resolved
glutton.go Outdated Show resolved Hide resolved
@tank0nf
Copy link
Author

tank0nf commented Jan 31, 2025

Hello @glaslos,

Thank you for your feedback! I’ve made the necessary changes and am looking forward to contributing further to this project.

Please feel free to let me know if any additional adjustments are needed, I’d be happy to make them.

Thanks again,
Tank0nf.

glutton.go Outdated Show resolved Hide resolved
@tank0nf
Copy link
Author

tank0nf commented Feb 1, 2025

Hi @glaslos,
I have made the necessary changes, let me know if their is any more issue.
Thank you,
Tank0nf.

@glaslos
Copy link
Member

glaslos commented Feb 1, 2025

Now the last change missing is in the Makefile

@tank0nf
Copy link
Author

tank0nf commented Feb 2, 2025

Hi @glaslos ,
I’ve made the necessary updates to the Makefile. Could you please review it and let me know if any further adjustments are needed?

Thank you,
Tank0nf

@@ -30,7 +30,7 @@ clean:
rm -rf bin/

run: build
sudo bin/server -i eth0
sudo bin/server -c config.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not necessary to define the config path. Also I don't think this will work since the config file is in a folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants