[Internal] SentinelOne v2 3.2.37#4
Conversation
saurabh-metron
changed the title
Packs/SentinelOne/Integrations/SentinelOne-V2/SentinelOne-V2.py
Outdated
Show resolved
Hide resolved
Packs/SentinelOne/Integrations/SentinelOne-V2/SentinelOne-V2.py
Outdated
Show resolved
Hide resolved
|
After adding the SectionOrder, There is no changes in the UI side, the config is looks same. Added this SectionOrder key as the pre-commit fix. |
| service_users, pagination = client.get_service_users_request(query_params) | ||
|
|
||
| if pagination and pagination.get("nextCursor") is not None: | ||
| demisto.results("Use the below cursor value to get the next page service users \n {}".format( |
There was a problem hiding this comment.
are we breaking here?
what happens to the page fetched already?
can we not get all the data in 1 GO? using pagination internally? instead of spitting out the page token
There was a problem hiding this comment.
in PROD - there won't be 1000s of apps or service users anyway ;)
There was a problem hiding this comment.
I agree in PROD there won't be 1000s of apps or service users. that's the reason command is making the API call once. and return the context data. In case any user has the more than 1000, in that case we are showing the cursor value in the war room, so that user can fetch the remaining 1000, and so on.
There was a problem hiding this comment.
Saurabh what do you think, please suggest here. thanks
There was a problem hiding this comment.
can we not make further API calls for further pages and return everything - instead of sending the page token
users may not know how to use it?
XSOAR team might say the same ;)
we are returning 2 things from a command - list of users/applications + page token when its more than 1000
ideally command should result only the asked details
| while pagination and pagination.get("nextCursor"): | ||
| demisto.debug("Got the next page for installed applications \n {}".format(pagination['nextCursor'])) | ||
| query_params['cursor'] = pagination['nextCursor'] | ||
| if query_params.get('limit'): |
There was a problem hiding this comment.
just add a comment when we need to remove the limit
There was a problem hiding this comment.
lets remove limit and cursor because we will get them everything
| | SentinelOne.InstalledApps.Account | string | The account name. | | ||
| | SentinelOne.InstalledApps.AccountId | string | The account ID. | | ||
| | SentinelOne.InstalledApps.ApplicationCatalogId | string | The application Catalog ID. | | ||
| | SentinelOne.InstalledApps.applicationCatalogName | string | The application Catalog name. | |
There was a problem hiding this comment.
| | SentinelOne.InstalledApps.applicationCatalogName | string | The application Catalog name. | | |
| | SentinelOne.InstalledApps.ApplicationCatalogName | string | The application Catalog name. | |
2 participants
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Must have