Repository navigation
🐛 Fix Windows diagnostics and device exports - #2719
Merged
Merged
Conversation
Use declared QDMI exports for hidden device libraries so CMake does not scan MSVC IPO objects. Keep Core exception handling and LLVM RTTI flags consistent on Windows without disabling STL exception support. Update deprecated LLVM APIs, handle discarded results, and avoid narrowing DD bit positions. Reject non-Boolean OpenQASM slice conditions instead of silently accepting them; extend the existing frontend regression test. Assisted-by: GPT-6 via Codex
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Use std::ignore for deliberately discarded values and fixed-width DD bit positions. Check fallible MLIR setup and bytecode writes, make jeff result conversions explicit, and type SHA-256 padding bytes before emplacement. Keep Core warnings enabled while limiting the Capn Proto and LLVM header suppressions to their affected target and includes. QIR exception-boundary warnings remain with the exception migration. Assisted-by: GPT-6 via Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Fix the independent Core diagnostics exposed by the Windows ARM64 release build. This PR is based directly on
mainand does not depend on #2715 or #2545.std::ignorefor deliberately discarded values, and check fallible test setup. Use fixed-width types for DD bit positions and SHA-256 padding bytes.The QIR C4297 warnings concern exceptions crossing the C entry points and remain part of #2545. The remaining warnings identified in the Windows ARM64 follow-up log are addressed here. No LTO or deployment policy changes are included.
Validation: native Release build; 3,952 tests passed and one expected skip; repository lint; whole-file C++ lint on the changed files. The added OpenQASM case fails before the fix and passes afterward. Focused CMake probes check the actual target helpers with MSVC/native and RTTI configurations, and both device libraries expose all 19 declared QDMI entry points. The Windows ARM64 build passed before the follow-up warning fixes; the latest changes still need MSVC CI validation.
AI assistance: Codex implemented these changes and specialist agents reviewed the MSVC flag and export handling.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).