FIX(cmake): Don't set WORKING_DIRECTORY for ExternalProject_Add() #6640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for a bug that appeared in a recent version of CMake. WORKING_DIRECTORY prepends the specified path to a list instead of using it directly, resulting in: cd /D D:\a\1\b\overlay\overlay_xcompile-prefix;D:\a\1\b\overlay\overlay_xcompile-prefix\src\overlay_xcompile-build For reference, this causes the build to fail on Windows with the following error: "The filename, directory name, or volume label syntax is incorrect." This commit simply removes the parameter from the ExternalProject_Add() call, since the default working directory is perfectly fine.
davidebeatrici
added
windows
build
…endencies Looks like targets are now built concurrently, which results in the installer failing to find the G15 and x64 overlay helpers. This commit marks the G15 and overlay targets as dependencies of the client, when they're enabled. As a bonus, plugins are now tied to their own dedicated target rather than the client's. This is required because the client's subdirectory is now included later on.
davidebeatrici
force-pushed
the
cmake-externalproject-no-working-directory
branch
from
6f93ae3 to
2a0683d
Compare
Hartmnt
approved these changes
Nov 29, 2024
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
|
This is HartBot beep boop beep. I have successfully and automatically backported this PR as #6641 |
davidebeatrici
deleted the
cmake-externalproject-no-working-directory
branch
Hartmnt
added a commit
that referenced
this pull request
Nov 29, 2024
… ExternalProject_Add()" to 1.5.x (#6641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for a bug that appeared in a recent version of CMake.
WORKING_DIRECTORYprepends the specified path to a list instead of using it directly, resulting in:cd /D D:\a\1\b\overlay\overlay_xcompile-prefix;D:\a\1\b\overlay\overlay_xcompile-prefix\src\overlay_xcompile-buildFor reference, this causes the build to fail on Windows with the following error:
"The filename, directory name, or volume label syntax is incorrect."
This commit simply removes the parameter from the
ExternalProject_Add()call, since the default working directory is perfectly fine.