[editor_gui] Improved object preview #692
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: - fixed object not appearing when selecting certain model ids - object rotation in viewport is centered - removed zoom out limit - added doublesided property to previewed element
|
Nice but some objects aren't supposed to be double sided? |
|
you're right, I thought about the outcomes of it, but I considered that there are more objects that need easier viewing (mostly landbits and vegetation) and there are only a few models that might look out of place when doublesided is applied to them we'll have to see if it's required to either keep the property or remove it |
chris1384
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: